Fall back to pkgconfig for finding netcdf-cxx4 #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwoerer
force-pushed
the
cmake-netcdf-pkgconfig
branch
from
bd5809e
to
22f28bc
Compare
dschwoerer
force-pushed
the
cmake-netcdf-pkgconfig
branch
from
22f28bc
to
c04a11a
Compare
ZedThree
reviewed
Mar 23, 2023
ZedThree
reviewed
Mar 23, 2023
ZedThree
reviewed
Apr 19, 2023
ZedThree
reviewed
Apr 19, 2023
ZedThree
previously approved these changes
Apr 19, 2023
ZedThree
approved these changes
Apr 20, 2023
|
The tests that haven't runner are because they're trying to use the removed 18.04 runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of https://cgit.freebsd.org/ports/tree/science/bout++/files/patch-CMakeLists.txt
@yurivict do you mind checking whether this patch works for you?