Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isUniform: Do not fail if numbers are only almost equal #2693

Merged
merged 5 commits into from
Apr 19, 2023
Merged

isUniform: Do not fail if numbers are only almost equal #2693

merged 5 commits into from
Apr 19, 2023

Conversation

dschwoerer
Copy link
Contributor

Resolves: #2692

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dschwoerer dschwoerer closed this Apr 17, 2023
@dschwoerer dschwoerer reopened this Apr 17, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dschwoerer
Copy link
Contributor Author

This time the docs CI passes, but 4 jobs are stuck at:

Requested labels: ubuntu-18.04
Job defined at: boutproject/BOUT-dev/.github/workflows/tests.yml@refs/pull/2693/merge
Waiting for a runner to pick up this job...

They are still stuck there after restarting :-(
They all passed before ...

@ZedThree
Copy link
Member

I assume these all pass, and we're just about to change the runners anyway

@ZedThree ZedThree merged commit 5379417 into master Apr 19, 2023
8 of 12 checks passed
@ZedThree ZedThree deleted the almost-equal branch April 19, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-invpar fails on aarch64, ppc64le and s390x
2 participants
@dschwoerer @ZedThree