Add support for PETSc & SLEPc 3.18 / 3.19 #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For newer PETSc set the option on the matrix
PETSc changed the default in 3.17 to PCJACOBI. There doesn't appear to be a programmatic way of setting this
Need to set old smoother and increase KSP max iterations to regain old tolerance
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
dschwoerer
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #2698, rebased into master
Unfortunately, newer PETSc defaults have reduced accuracy in our tests. See #2698 (comment) for details
PCJACOBI apparently works on GPU but it seems like a complete downgrade on CPU.
We also need a fix for PETSc reporting errors from our interface mixing
VecGetValuesandVecSetValuescalls. I'm not sure there's a way round this, so we might need a different implementation. I'll make a separate issue for that, because it doesn't seem to affect the result.