Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FV::Div_a_Grad_perp Y alignment #2722

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Conversation

bendudson
Copy link
Contributor

Raises exception that Y alignment is incorrect when calling fromFieldAligned at the end of this function. Need to set aligned when constructing field.

Raises exception that Y alignment is incorrect when calling
fromFieldAligned. Need to set aligned when constructing field.
@bendudson bendudson added bugfix small-change Changes less than 100 lines - should be quick to review labels Jun 15, 2023
@bendudson bendudson added this to the BOUT-5.1 milestone Jun 15, 2023
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that covered by a CI test?
If not, it would be nice to add one ...

@bendudson bendudson merged commit 2e4fdbf into v5.1.0-rc Aug 6, 2023
23 checks passed
@bendudson bendudson deleted the bugfix-fvops-yalign branch August 6, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants