Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI install natsort #2723

Merged
merged 1 commit into from
Jun 15, 2023
Merged

CI install natsort #2723

merged 1 commit into from
Jun 15, 2023

Conversation

bendudson
Copy link
Contributor

In CI install natsort package.

Required from boutdata.restart, in tests/integrated/test-restart-io

@bendudson
boutdata requires natsort
d99fab3 
In CI install natsort package
@bendudson bendudson added tests bugfix small-change Changes less than 100 lines - should be quick to review labels Jun 15, 2023
@bendudson bendudson added this to the BOUT-5.1 milestone Jun 15, 2023
@ZedThree
Copy link
Member

Error is g++: error: netcdf: No such file or directory. I think I might have clobbered the fix when merging next into the v5.1.0-rc branch

@dschwoerer
Copy link
Contributor

That might also have been broken by me.

The tests were only merged, so it was not easy to detect this before.
I cannot reproduce this on my fedora, I end up with the full path.

Would it make sense to try to sanitise the LDFLAGS? And if it is neither starting with - nor a valid path prefix it with -l?

dschwoerer
dschwoerer approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes an issue, the static failures are unrelated, so this can be merged 👍

@bendudson bendudson merged commit 7bcec6f into v5.1.0-rc Jun 15, 2023
19 of 21 checks passed
@bendudson bendudson deleted the ci-install-natsort branch June 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwoerer dschwoerer dschwoerer approved these changes

Assignees
No one assigned
Labels
bugfix small-change Changes less than 100 lines - should be quick to review tests
Projects
None yet
Milestone
BOUT-5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendudson @ZedThree @dschwoerer