Bump clang-tidy-review version
#2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwoerer
approved these changes
Jun 19, 2023
|
Err, good question! Turns out we explicitly turned it off on RC branches: on:
pull_request:
paths:
- '**.cxx'
- '**.hxx'
branches-ignore:
# Release candidate branches tend to have big PRs which causes all sorts of problems
- 'v*rc'Could put it into master/next instead I suppose, along with some C++ changes -- might be better to just wait and see on some other PR? Not ideal |
|
Failing tests are the static build which was fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes now get uploaded as a build artefact, which can then be downloaded and applied locally