Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving compatibility with fmt 10 #2730

Merged
merged 10 commits into from
Jul 26, 2023
Merged

Improving compatibility with fmt 10 #2730

merged 10 commits into from
Jul 26, 2023

Conversation

dschwoerer
Copy link
Contributor

@dschwoerer dschwoerer commented Jun 28, 2023

Todo:

  • check this resolves the FTBFS

@ZedThree
Copy link
Member

Fedora is failing with:

Unknown argument "builddep" for command "dnf5". Add "--help" for more information about the arguments.

But there's also a compile error:

/home/runner/work/BOUT-dev/BOUT-dev/src/solver/impls/imex-bdf2/imex-bdf2.cxx:1244:25: error: ‘SNESGetConvergedReasons’ was not declared in this scope; did you mean ‘SNESGetConvergedReason’?

The suggestion is wrong, and I think, in classic PETSc fashion, there's a completely different thing to use here: SNESGetConvergedReasonString

Also, we now use this pattern in quite a few places (I count at least 7), so might be worth wrapping up in a helper function?

@dschwoerer dschwoerer marked this pull request as ready for review July 2, 2023 22:14
@ZedThree ZedThree merged commit 9c22f24 into v5.1.0-rc Jul 26, 2023
1 check passed
@ZedThree ZedThree deleted the fmt10 branch July 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants