-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release process #2734
base: v5.1.0-rc
Are you sure you want to change the base?
Automate release process #2734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused why this was not black formatted, but I think that's because it is in a fork, and CI is not enabled.
a5e7f09
to
b4db274
Compare
apply_fixes(replacements, source) yes_or_no(question) create_patch(filename, original, modified) [unfinished]
[skip ci]
…run("cd",... does nothing as it's a separate process). [skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
47342bf
to
80eced1
Compare
[skip ci]
"nick-walkden": KnownAuthor("Walkden", "Nicholas"), | ||
"ZedThree": KnownAuthor("Hill", "Peter"), | ||
"tomc271": KnownAuthor("Chapman", "Tom"), | ||
"j-b-o": KnownAuthor("Omotani", "John"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just noticed this. j-b-o is not John, I will ask @j-b-o whether she wants to be included in the authors list ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"j-b-o": KnownAuthor("Omotani", "John"), | |
"j-b-o": KnownAuthor("Bold" "Jessica"), |
|
||
For the 'bout-next' version number, | ||
the 'minor' version number of the provided version will be incremented by 1, | ||
e.g. 5.10.3 -> 5.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that is not what we want?
For master we want to bump the patch level
for next we want to bump the minor or major.
And always, we want to reset all less significant numbers to zero.
I think we might not need to provide the version we want to bump to, because that has already been done, but rather say what the next version bump is going to be.
So when we want to release say 5.1.0 we say we want 5.1.1 for the master branch and 5.2.0 for the next branch, as 5.1.0 is already stored as the future version ( I think in CMakeLists.txt and backend.py)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good points! Might need some more involved logic here
[skip ci] Co-authored-by: David Bold <dschwoerer@users.noreply.github.com>
No description provided.