Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process #2734

Open
wants to merge 33 commits into
base: v5.1.0-rc
Choose a base branch
from

Conversation

tomc271
Copy link
Collaborator

@tomc271 tomc271 commented Jul 11, 2023

No description provided.

@tomc271 tomc271 requested a review from ZedThree July 11, 2023 10:08
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused why this was not black formatted, but I think that's because it is in a fork, and CI is not enabled.

@tomc271 tomc271 marked this pull request as draft July 12, 2023 10:16
apply_fixes(replacements, source)
yes_or_no(question)
create_patch(filename, original, modified)
[unfinished]
bin/update_citations.py Outdated Show resolved Hide resolved
bin/update_citations.py Outdated Show resolved Hide resolved
bin/update_citations.py Outdated Show resolved Hide resolved
bin/update_citations.py Outdated Show resolved Hide resolved
bin/update_citations.py Outdated Show resolved Hide resolved
bin/update_version_number_in_files.py Show resolved Hide resolved
bin/update_version_number_in_files.py Outdated Show resolved Hide resolved
bin/update_version_number_in_files.py Outdated Show resolved Hide resolved
bin/update_version_number_in_files.py Outdated Show resolved Hide resolved
bin/update_version_number_in_files.py Outdated Show resolved Hide resolved
@tomc271 tomc271 marked this pull request as ready for review August 21, 2023 18:11
@ZedThree ZedThree changed the base branch from next to v5.1.0-rc September 20, 2023 13:17
ZedThree
ZedThree previously approved these changes Sep 20, 2023
"nick-walkden": KnownAuthor("Walkden", "Nicholas"),
"ZedThree": KnownAuthor("Hill", "Peter"),
"tomc271": KnownAuthor("Chapman", "Tom"),
"j-b-o": KnownAuthor("Omotani", "John"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed this. j-b-o is not John, I will ask @j-b-o whether she wants to be included in the authors list ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, thanks for catching this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"j-b-o": KnownAuthor("Omotani", "John"),
"j-b-o": KnownAuthor("Bold" "Jessica"),

bin/update_citations.py Outdated Show resolved Hide resolved

For the 'bout-next' version number,
the 'minor' version number of the provided version will be incremented by 1,
e.g. 5.10.3 -> 5.11.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is not what we want?

For master we want to bump the patch level
for next we want to bump the minor or major.

And always, we want to reset all less significant numbers to zero.

I think we might not need to provide the version we want to bump to, because that has already been done, but rather say what the next version bump is going to be.

So when we want to release say 5.1.0 we say we want 5.1.1 for the master branch and 5.2.0 for the next branch, as 5.1.0 is already stored as the future version ( I think in CMakeLists.txt and backend.py)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good points! Might need some more involved logic here

[skip ci]

Co-authored-by: David Bold <dschwoerer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants