Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix version detection from git tag #2753

Merged
merged 1 commit into from
Oct 4, 2023
Merged

CMake: Fix version detection from git tag #2753

merged 1 commit into from
Oct 4, 2023

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Oct 4, 2023

Slight emergency fix for v5.1.0! This was failing to even start configuring with error:

CMake Error at CMakeLists.txt:46 (project):
  VERSION "v5.1.0" format invalid.

Turns out we weren't removing the leading v from the git tag. Guess we need a better test for this?

@bendudson bendudson merged commit 74b905b into master Oct 4, 2023
6 of 22 checks passed
@bendudson bendudson deleted the fix-cmake-version branch October 4, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendudson bendudson bendudson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZedThree @bendudson