Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .zpm for sign-independent coding #2888

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Add .zpm for sign-independent coding #2888

wants to merge 2 commits into from

Conversation

dschwoerer
Copy link
Contributor

No description provided.

@ZedThree
Copy link
Member

This is a bit of a frustrating situation, I guess we didn't allow zp(-1) as it would involve extra branching to avoid negative numbers in the mod for periodicity. It would be good to know if this is really still a problem performance-wise.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dschwoerer
Copy link
Contributor Author

I think it is not so bad - if you know the sign of the offset, you can pick a specific one, otherwise the other.
Even if it is not an issue right now with a specific compiler, it might become one for a different compiler or architecture (e.g. GPUs)

If we allow z splitting, that anyway changes 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dschwoerer @ZedThree