Arguments for open_mfdataset() now match signature in xarray master branch #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-02 09:03:43 UTC |
ZedThree
approved these changes
Jul 2, 2019
johnomotani
pushed a commit
that referenced
this pull request
Dec 11, 2019
Arguments for open_mfdataset() now match signature in xarray master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to merge my pull request into xarray, for now the argument signature of
xarray.open_mfdataset()has been reverted to be backwards compatible.This will change again in the future when the N-dimensional combine becomes public API, but for now we should use xarray's master branch instead of my fork, and match the signature.
@ZedThree I think this would be be appropriate PR in which to change the dependency?