sitemaps: Remove url validation

bouzuya · Jan 13, 2023 · c61405f · c61405f
1 parent d409fa8
commit c61405f
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/sitemaps/src/writer/loc.rs b/sitemaps/src/writer/loc.rs
@@ -21,10 +21,11 @@ impl<'a> TryFrom<&'a str> for Loc<'a> {
         if value.chars().count() >= 2048 {
             return Err(Error);
         }
-        let u = url::Url::parse(value).map_err(|_| Error)?;
-        if u.as_str() != value {
-            return Err(Error);
-        }
+        // too slow
+        // let u = url::Url::parse(value).map_err(|_| Error)?;
+        // if u.as_str() != value {
+        //     return Err(Error);
+        // }
         Ok(Self(Cow::Borrowed(value)))
     }
 }
@@ -51,7 +52,7 @@ mod tests {
         assert_eq!(Loc::try_from(s)?.into_inner(), s);
 
         let s = "https://example.com";
-        assert!(Loc::try_from(s).is_err());
+        assert_eq!(Loc::try_from(s)?.into_inner(), s);
 
         let s = format!("https://example.com/{}", "a".repeat(2028));
         assert_eq!(s.len(), 2048);