Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link replacement issues with PageForms (ParseOnRender) #58

Closed
zyzzyxdonta opened this issue Sep 27, 2021 · 3 comments
Closed

Link replacement issues with PageForms (ParseOnRender) #58

zyzzyxdonta opened this issue Sep 27, 2021 · 3 comments

Comments

@zyzzyxdonta
Copy link

Hi,

we noticed that LinkTitles doesn't work well with the PageForms extension. With ParseOnRender enabled, it tries to replace words in dropdown menus and placeholder texts in text boxes. Sometimes it works and creates a link (which is still a bit annoying in dropdown menus), other times the replacement fails and it just shows <!--LINK'" 0:0--> and the original text is not shown at all. I didn't try ParseOnEdit.
@bovender
Copy link
Owner

Sorry for letting you wait so long. I don't use the PageForms extension. Could you please let me know if this extension adds typical tags to a page? Then I could exclude those from being parsed by LinkTitles.

@zyzzyxdonta
Copy link
Author

No worries 😄
I think everything is just <input></input> and <select></select> tags.

bovender added a commit that referenced this issue Jan 12, 2022
@bovender
Exclude stuff betweeen input and select tags.
4e868e3 
Addresses #58 to prevent LinkTitles from interfering with the
PageForms extension. Needs testing.
@zyzzyxdonta
Copy link
Author

Thank you! We will test the fix at the next opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bovender @zyzzyxdonta