NefCore FP #114
Merged
NefCore FP #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truizlop
requested changes
Jan 21, 2020
| @@ -4,18 +4,17 @@ import XCTest | |||
| @testable import NefCore | |||
|
|
|||
| class JekyllTests: XCTestCase { | |||
There was a problem hiding this comment.
We may want to consider to rewrite these tests as snapshot tests, or combine them, as they are quite prone to change if we add spaces, new lines or such. But they look much nicer now anyways!
There was a problem hiding this comment.
Sure, after the refactor we could think about how to create a robust-base test code :)
truizlop
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Related issue #112
Description
In this PR we have migrated the NefCore module fo functional-programming using
Bow