Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA sessions #146

Merged
merged 6 commits into from Mar 26, 2020
Merged

QA sessions #146

merged 6 commits into from Mar 26, 2020

Conversation

miguelangel-dev
Copy link
Member

Details

After some conversation with users, using the last nef version:

  • Users add its code between // nef:begin:hidden so they do not understand why the output of the render is blank ~> update the template as in macOS, do not add any default helper code.
  • When the render fails, nef is not showing descriptive information ~> update the message of error when renders fail because of AST, empty output and fails to render a node.

@miguelangel-dev miguelangel-dev changed the base branch from master to develop March 25, 2020 10:22
project/Core/Models/CoreRenderError.swift Outdated Show resolved Hide resolved
project/Core/Models/CoreRenderError.swift Outdated Show resolved Hide resolved
project/Core/Models/CoreRenderError.swift Outdated Show resolved Hide resolved
miguelangel-dev and others added 3 commits March 26, 2020 11:00
Co-Authored-By: Tomás Ruiz-López <truizlop@gmail.com>
Co-Authored-By: Tomás Ruiz-López <truizlop@gmail.com>
Co-Authored-By: Tomás Ruiz-López <truizlop@gmail.com>
@miguelangel-dev miguelangel-dev merged commit 04e5c52 into develop Mar 26, 2020
@miguelangel-dev miguelangel-dev deleted the general_improvements_qa branch March 26, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants