Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug - delete project #70

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix bug - delete project #70

merged 2 commits into from
Jun 24, 2019

Conversation

miguelangel-dev
Copy link
Member

@miguelangel-dev miguelangel-dev commented Jun 24, 2019

Issues

Description

If the project name input is the same as the playground page, then Jekyll, carbon, markdown remove the project folder and fails - LOL

How is it implemented?

Before to clean output project, check if it is the same as input project - in this case, stop the script and launch error with suggestions for the output path.

Note: I have taken advantage of this issue to refactor in only one place how to resolve absolute paths. (nef-common)

@miguelangel-dev miguelangel-dev changed the title Fix bug in paths Fix bug - delete project Jun 24, 2019
@miguelangel-dev miguelangel-dev changed the base branch from carbon-parametrize-cli to develop June 24, 2019 14:25
@miguelangel-dev miguelangel-dev merged commit 4648cd8 into develop Jun 24, 2019
@miguelangel-dev miguelangel-dev deleted the fix-paths branch June 24, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants