set GIT_SSL_NO_VERIFY for opposite value than strictSsl

bower · Jan 23, 2016 · f0a54d0 · f0a54d0 · vrmartins · Aug 7, 2018
1 parent 1d73764
commit f0a54d0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/core/resolvers/GitResolver.js b/lib/core/resolvers/GitResolver.js
@@ -26,9 +26,7 @@ function GitResolver(decEndpoint, config, logger) {
     // anyway
     mkdirp.sync(config.storage.empty);
     process.env.GIT_TEMPLATE_DIR = config.storage.empty;
-    if (!config.strictSsl) {
-        process.env.GIT_SSL_NO_VERIFY = 'true';
-    }
+    process.env.GIT_SSL_NO_VERIFY = (!config.strictSsl).toString();
 
     Resolver.call(this, decEndpoint, config, logger);
 

diff --git a/test/core/resolvers/gitResolver.js b/test/core/resolvers/gitResolver.js
@@ -50,10 +50,16 @@ describe('GitResolver', function () {
             expect(process.env).to.not.have.property('GIT_SSL_NO_VERIFY');
 
             resolver = new GitResolver(decEndpoint, defaultConfig(), logger);
-            expect(process.env).to.not.have.property('GIT_SSL_NO_VERIFY');
+            expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','false');
+            delete process.env.GIT_SSL_NO_VERIFY;
 
             resolver = new GitResolver(decEndpoint, defaultConfig({strictSsl: false}), logger);
             expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','true');
+            delete process.env.GIT_SSL_NO_VERIFY;
+
+            resolver = new GitResolver(decEndpoint, defaultConfig({strictSsl: true}), logger);
+            expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','false');
+            delete process.env.GIT_SSL_NO_VERIFY;
         });
     });