Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bower resolves range >=1.2.x <=1.4.x incorrectly #1817

Closed
arty-name opened this issue Jun 10, 2015 · 0 comments
Closed

Bower resolves range >=1.2.x <=1.4.x incorrectly #1817

arty-name opened this issue Jun 10, 2015 · 0 comments

Comments

@arty-name
Copy link

Simplest way to reproduce: add following dependencies to your bower.json:

"dependencies": {
    "angular": "1.4.0",
    "oclazyload": "1.0.1"
},

When you run bower install you get following output:

Unable to find a suitable version for angular, please choose one:
    1) angular#>=1.2.x <=1.4.x which resolved to 1.3.16 and is required by oclazyload#1.0.1
    2) angular#1.4.0 which resolved to 1.4.0 and is required by test

According to the semver calculator version 1.4.0 matches the range >=1.2.x <=1.4.x and it should be used.
@MatthewMaher MatthewMaher mentioned this issue Jul 7, 2015
Closed
@peterkc peterkc mentioned this issue Jul 12, 2015
Closed
peterkc added a commit to ZephyrHealth/bower that referenced this issue Jul 12, 2015
@peterkc
upgrade to newer semver.js dependency
1bdd4f6 
Upgrading to latest version of semver to resolve (bower#1817, bower#1845).

Possible breaking changes in regards to the way semvers handles pre-releases.

If a version has a prerelease tags (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

For example, the range >1.2.3-alpha.3 would be allowed to match the version 1.2.3-alpha.7, but it would not be satisfied by 3.4.5-alpha.9. See [semvers](https://github.com/npm/node-semver#prerelease-tags) additional details.
peterkc added a commit to ZephyrHealth/bower that referenced this issue Jul 12, 2015
@peterkc
upgrade to newer semver, fixes bower#1817,bower#1845,bower#1851
8a3eb84 
Upgrading to latest version of semver to fix (bower#1817, bower#1845, bower#1851).

Possible breaking changes in regards to the way semvers handles pre-releases.

If a version has a prerelease tags (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

For example, the range >1.2.3-alpha.3 would be allowed to match the version 1.2.3-alpha.7, but it would not be satisfied by 3.4.5-alpha.9. See [semvers](https://github.com/npm/node-semver#prerelease-tags) additional details.
peterkc added a commit to ZephyrHealth/bower that referenced this issue Jul 12, 2015
@peterkc
upgrade to newer semver, fixes bower#1817,bower#1845,bower#1851
cdb9fbe 
Upgrading to latest version of semver to fix (bower#1817, bower#1845, bower#1851).

Possible breaking changes in regards to the way semvers handles pre-releases.

If a version has a prerelease tags (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

For example, the range >1.2.3-alpha.0 would be allowed to match the version 1.2.3-alpha.7, but it would not be satisfied by * or 1.2.3. See [semvers](https://github.com/npm/node-semver#prerelease-tags) additional details.
@peterkc peterkc mentioned this issue Jul 12, 2015
Merged
peterkc added a commit to ZephyrHealth/bower that referenced this issue Jul 17, 2015
@peterkc
upgrade to newer semver, fixes bower#1817,bower#1845,bower#1851
7720ddb 
Upgrading to latest version of semver to fix (bower#1817, bower#1845, bower#1851).

Possible breaking changes in regards to the way semvers handles pre-releases.

If a version has a prerelease tags (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

For example, the range >1.2.3-alpha.0 would be allowed to match the version 1.2.3-alpha.7, but it would not be satisfied by * or 1.2.3. See [semvers](https://github.com/npm/node-semver#prerelease-tags) additional details.
sheerun added a commit that referenced this issue Jul 28, 2015
@sheerun
Merge pull request #1852 from ZephyrHealth/fix/update-semver
9c9cd81 
upgrade to newer semver, fixes #1817,#1845,#1851
sheerun added a commit that referenced this issue Aug 25, 2015
@sheerun
Revert "upgrade to newer semver, fixes #1817,#1845,#1851"
fe9a1bb 
This reverts commit 8744449.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arty-name