-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointing dependency to specific commit with only numbers in it fails #2319
Comments
Is there a concrete example you are referring to and can share? |
@benmann let's take d3 for example
results in error
I understand that this is specific bug, and it can be fixed by copying more characters from commit hash that is provided. But it would be cool if bower could understand that probably there are no versions higher than, say, 1 million, and would treat it as a commit hash. |
Until someone decides to make version by the timestamp, like 20160602 :( |
@sheerun Yes, you are totally right. And you can't check if such version exists, and if it doesn't, check for such commit. In this case, if somebody makes mistake and writes 20160601 instead of 20160602, it wouldn't be reliable to check commit that starts with 20160601, as it could exists. |
Output of
bower -v && npm -v && node -v
:Steps to reproduce the issue:
Describe the results you received:
I expected it to find commit with hash starting with 70041869 and download dependency from it
Describe the results you expected:
Bower told me
and stopped installing
Additional information:
I understand that this feature that is rarely used, and commit hashes almost always have some alphabetic charactes at the beggining, but still, this is a problem that might occur unexpectedly.
The text was updated successfully, but these errors were encountered: