Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform the user of missing properties in bower.json #694

Closed
sindresorhus opened this issue Jul 30, 2013 · 2 comments
Closed

Inform the user of missing properties in bower.json #694

sindresorhus opened this issue Jul 30, 2013 · 2 comments
Labels
enhancement low priority

Comments

@sindresorhus
Copy link
Contributor

Our current biggest problem except for many packages not having a bower.json is that they include a lot of junk which makes them a lot larger than they would need too. I think we should suggest to the author at publish to make use of the ignore property for unneeded files.

We could do the same suggesting about making use of of main property.

If we want authors to do good, we need to help them do so.
aeisenberg pushed a commit to aeisenberg/bower that referenced this issue Aug 22, 2013
Inform user of missing properties on publish
0c5c2f0 
Initial fix for issue bower#694
Simple prompt for asking users to create a better
bower.json.
@aeisenberg aeisenberg mentioned this issue Aug 22, 2013
Closed
@aeisenberg
Copy link
Contributor

I couldn't find any tests in this area. Please let me know if I'm missing something.

aeisenberg pushed a commit to aeisenberg/bower that referenced this issue Aug 25, 2013
Inform user of missing properties on publish and install
7afea8b 
Fix for issue bower#694

Simple prompt for asking users to create better bower.json on publish.

Also warn users when installing package with missing properties.

Test case included
aeisenberg pushed a commit to aeisenberg/bower that referenced this issue Aug 25, 2013
Warn users when installing package with missing properties.
412c6d6 
Fix for issue bower#694. Test case included.
aeisenberg pushed a commit to aeisenberg/bower that referenced this issue Sep 27, 2013
more work on issue bower#694
a3757c9
@wibblymat wibblymat removed this from the 1.3.0 milestone Apr 3, 2014
@sheerun sheerun added this to the 1.4.x milestone Jun 19, 2014
sheerun pushed a commit that referenced this issue Jun 20, 2014
@sheerun
Warn users when installing package with missing properties.
1690dd4 
Fix for issue #694. Test case included.
@sheerun sheerun modified the milestones: 1.3.x, 1.4.x Jun 20, 2014
@sheerun
Copy link
Contributor

sheerun commented Jul 2, 2014

Implemented in 1.3.6.

@sheerun sheerun closed this as completed Jul 2, 2014
@huerlisi huerlisi mentioned this issue Apr 15, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low priority
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sindresorhus @sheerun @aeisenberg @wibblymat