Resolution Persistence Failure

[mike-spainhower]

Overview

There is a scenario under which resolution persistence does not actually persist a resolution selection. This occurs when depending directly upon a package that is also a second order dependency. If the branch on the first order dep is different than the second order dep, the persistence does not work.

Results

Expected

If bower prompts to persist a resolution to bower.json (see #532 ) and one is selected, that selection should be used after running

rm -Rf bower_components && bower cache clean && bower install

Actual

Bower persists to bower.json, but even then Bower again prompts about persistence on bower install

Reproduction

$ git clone git@github.com:mike-spainhower/res-persist-test-app.git
$ bower install
$ rm -Rf bower_components && bower cache clean && bower install

Observe that although custom is persisted to bower.json, Bower keeps prompting for a manual resolution.

Impact

• Automated tools (e.g., CI) will not terminate
• Contributors unfamiliar with project dependencies may make incorrect selection

Fix

Allow branch to be used as resolution property.

[satazor]

@mike-spainhower this only happens when branch is different, and has nothing to do with different repos (sources).

[satazor]

@mike-spainhower #819, can you test it to see if it works?

[mike-spainhower]

@satazor Thanks for the quick turnaround and good call on repo vs. branch; I should have isolated the issue better. I tested with the original repo that was giving me trouble and found an edge case. I put in a PR to your branch that fixes it.