Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower init doesn't update bower ignore paths #854

Closed
chrisjlee opened this issue Sep 5, 2013 · 1 comment · Fixed by #887
Closed

Bower init doesn't update bower ignore paths #854

chrisjlee opened this issue Sep 5, 2013 · 1 comment · Fixed by #887
Milestone

Comments

@chrisjlee
Copy link

Problem/Issue

If you have a .bowerrc file and change the directory the bower ignore paths do not get updated accordingly.

Steps to reproduce:

Create .bowerrc file:

{
  "directory" : "js/components"
}

Run bower init setup

bower.json

  "ignore": [
    "**/.*",
    "node_modules",
    "components" // shouldn't this be js/components ?
  ]
}

Apologies, i'm a bit new at this. Would love to submit a PR if someone can point me in the right direction.

@satazor
Copy link
Member

satazor commented Sep 5, 2013

@chrisjlee good point, yes probably that makes sense. https://github.com/bower/bower/blob/master/lib/commands/init.js#L286 should be changed to config.directory. Note that the config var must be passed into that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants