New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same package names but different endpoints now have different caches. #109
Conversation
cp.on('close', function (code) { | ||
if (code != 0) return this.emit('error', new Error('Git status: ' + code)); | ||
this.emit('cache'); | ||
}.bind(this)); | ||
}.bind(this)); | ||
}.bind(this)); | ||
}.bind(this)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, Node.js your async makes be cry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callback hell!!!
@@ -365,7 +364,7 @@ Package.prototype.exists = function (callback) { | |||
|
|||
Package.prototype.clone = function () { | |||
template('action', { name: 'cloning', shizzle: this.gitUrl }).on('data', this.emit.bind(this, 'data')); | |||
this.path = path.resolve(config.cache, this.name); | |||
this.path = path.resolve(config.cache, this.name, this.resourceId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why indent this =
so far?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, was not intentional.
lgtm, just little comments |
@fat all done! |
Same package names but different endpoints now have different caches.
Fixes #106