-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bower update --save
functionality
#2062
Conversation
Looks promising :) Could you squash the commits and force-push them? |
@sheerun Definitely. Is AppVeyor failing because of this PR? Or is it just having a bad day? |
Yes, appveyor is failing because of timeout on one test. Maybe you need to use nock to mock some connection or something (optionally increase maximum timeout for this test). Don't look at node 0.10 on appveyor because it's failing for unrelated issues.. |
ab80b3a
to
d2ba80e
Compare
Cool, for now I just increased the timeout for that test file. I'll look into properly mocking the http requests when I get some more time. There are other |
Should I wait until you add tests for updating a single package? |
+1 |
Add `bower update --save` functionality
Thank you |
I've just runned |
It will be released as bower 1.6.9 |
Oh, ok |
This PR lets
bower update
updatebower.json
via a--save
flag. It mimics npm's update behavior.Current behavior:
bower update
updates components inbower_components/
while respecting components' semver inbower.json
. For example, if bootstrap is listed as~2.2.0
inbower.json
, runningbower update
will updatebower_components/bootstrap
to 2.2.2 because 2.2.2 is the latest version greater than 2.2.0 but less than 3.0.0.bower.json
is not modified.New behavior proposed by this PR:
bower update --save
does the same stuff above but it also editsbower.json
. In the above example, bootstrap would now be listed inbower.json
as~2.2.2
.bower update --save-dev
works the same but for dev dependencies.bower_components/
but aren't listed inbower.json
) are ignored.See #2035 and #1468.
@bower/contributors please review. Feedback is appreciated.