Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying info message when user login via bower login #2114

Closed
wants to merge 2 commits into from
Closed

Displaying info message when user login via bower login #2114

wants to merge 2 commits into from

Conversation

rajasekarm
Copy link
Contributor

Currently, we don't show any message when logged in via bower login.
In this pull request, I have shown an info message like,

bower EAUTH Logged in as username

I have used bower logger for showing the info message.

@rajasekarm
Copy link
Contributor Author

Gave pull request as single commit.

@sheerun
Copy link
Contributor

sheerun commented Dec 21, 2015

You don't need to create another PR. You can just git push --force.

Can you add message when someone logins with login/password instead of authkey?

@rajasekarm
Copy link
Contributor Author

Added info message for both login, via normal and 2 factor auth mode.

Displaying info message when user login via bower login

Login message added for 2 factor authentication also
@sheerun
Copy link
Contributor

sheerun commented Dec 31, 2015

There's a CI error to fix:

Running "jshint:files" (jshint) task

lib\commands\install.js
11 | return;
^ Unreachable 'return' after 'throw'.

1 error in 105 files

@al3rez al3rez closed this Dec 31, 2015
@rajasekarm
Copy link
Contributor Author

oops.. I will resolve the issue and will give again.

@rajasekarm
Copy link
Contributor Author

It is already merged by @azbshiri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants