Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decompressing a unix zip fails if external file attribute is 0 #71

Open
shadargee1982 opened this issue Nov 25, 2020 · 3 comments
Open

Comments

@shadargee1982
Copy link
Contributor

We've run into a situation where an archive created on Unix can sometimes create a zip file where the external file attribute is 0. This causes this line to fail since 0 isn't in the list of types. Much like how archives created in Windows type property defaults to 'File', the Unix decompression should as well.

@sheerun
Copy link
Contributor

sheerun commented Nov 25, 2020

You're using decompress-zip directly or through some other software?

@shadargee1982
Copy link
Contributor Author

using it in an AzureDev Ops pipeline task. The platform spins up a Unix machine, installs the necessary libraries (decompress-zip), and then essentiall calls extract. Snippet:

var unzipper = new DecompressZip(zipLocation);
...
unzipper.extract({
	path: unzipLocation
});

shadargee1982 added a commit to shadargee1982/decompress-zip that referenced this issue Jan 4, 2021
@shadargee1982
Copy link
Contributor Author

@sheerun - I've submitted a PR for this issue. Can you please take a look?

sheerun added a commit that referenced this issue Jan 11, 2021
#71: default external file attributes to File for Unix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants