Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft edge has no "short version name" in satisfies #265

Closed
BleedingDev opened this issue Oct 29, 2018 · 6 comments
Closed

Microsoft edge has no "short version name" in satisfies #265

BleedingDev opened this issue Oct 29, 2018 · 6 comments

Comments

@BleedingDev
Copy link

Other browsers have something like "chrome", "firefox" or "safari", but with Microsoft Edge I had to use "Microsoft Edge".
It would be better to have "edge" or at least "msedge".

@BleedingDev BleedingDev changed the title Microsoft edge has now "short version" in satisfies Microsoft edge has no "short version name" in satisfies Oct 29, 2018
@lancedikson
Copy link
Collaborator

Hi, @pegak. Good thought. I haven't brought aliases to the lib yet, but it's supposed to have real browser names just to avoid any confusion and have as much declarativity and simplicity as it can. But, I think at some point we could improve that and make a list of short aliases for each browser.

@willamesoares
Copy link
Contributor

Hey @lancedikson, do you think this is still valid? If so, would you give us more clarification on what's the expected work for this and if you have any assumptions on how we would support aliases?
I'm willing to work on this issue, so let me know.

@lancedikson
Copy link
Collaborator

hi @willamesoares, glad to hear, you're willing to take this up. I don't have any specific logic in mind about that stuff, but I guess, we should have a special entity here, like NameResolver, which would be a map of some internal value to different aliases (shortcuts). At first, as I can see we need only one-way resolving, which would translate msedge|ms edgeMicrosoft Edge for internal usage in the parser. I think that's it for now :) Of course, this resolver should contain an extending map — we can have aliases for any other browsers if we need. But, we should be careful with these aliases as they can overlap with platforms or any other names in the end, which will be confusing :)

@willamesoares
Copy link
Contributor

Hey @lancedikson, I've just opened a PR #295 for implementing this.
I believe that would possibly be an initial version for what we're aiming at here. I would appreciate any feedback on that.

Thanks for the opportunity ;)

@willamesoares
Copy link
Contributor

Also, I noticed a couple of preexisting ESLint errors that are currently blocking that PR. Those are mostly related to the way we export/import Utils methods.
I created the issue #296 for that.

@lancedikson
Copy link
Collaborator

Forgot to close this one after merging the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants