-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft edge has no "short version name" in satisfies #265
Comments
Hi, @pegak. Good thought. I haven't brought aliases to the lib yet, but it's supposed to have real browser names just to avoid any confusion and have as much declarativity and simplicity as it can. But, I think at some point we could improve that and make a list of short aliases for each browser. |
Hey @lancedikson, do you think this is still valid? If so, would you give us more clarification on what's the expected work for this and if you have any assumptions on how we would support aliases? |
hi @willamesoares, glad to hear, you're willing to take this up. I don't have any specific logic in mind about that stuff, but I guess, we should have a special entity here, like |
Hey @lancedikson, I've just opened a PR #295 for implementing this. Thanks for the opportunity ;) |
Also, I noticed a couple of preexisting ESLint errors that are currently blocking that PR. Those are mostly related to the way we export/import |
Forgot to close this one after merging the PR :) |
Other browsers have something like "chrome", "firefox" or "safari", but with Microsoft Edge I had to use "Microsoft Edge".
It would be better to have "edge" or at least "msedge".
The text was updated successfully, but these errors were encountered: