-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox on iPad detected incorrectly, again #401
Comments
the same problem on ipad. UserAgent: ‘Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.4 Safari/605.1.15’ bowser output: browser: { name: 'Safari', version: '13.0.4' }, |
The fix has been released as 2.10.0. Check it out, please :) |
I have tested with the library vesrions 2.10.0 as well 2.11.0, on the iPadOS 13.4.1 and Firefox Version 28.1 (19225) but the bug is still present: browser: { name: 'Safari', version: '13.1' }, |
@VesnaVojinovic, could you please provide the UserAgent string of the browser? |
Wait, is it Firefox? There's no way to get it from the UserAgent string. |
It would be possible if it had |
believe it or not, but that was really Firefox |
I am testing a webapp on an IPAD and have the exact same agent as @VesnaVojinovic . |
Previous issue: #378
It looks like those maniacs have done it again, and the UA string for Firefox/iPad was changed in the next version after the fix I did. Here are the UAs.
Firefox on iPad (current version):
Firefox on iPad (previous version; test was already added, Bowser detects correctly):
Firefox on iPhone (current version; this is significantly different from the string in the tests but Bowser detects it correctly):
Notably the
Version/<iOS version>
part of the UA has disappeared, which I was using in my previous fix to disambiguate the iPad version.I can't come up with a fix for this, unfortunately. If I remove the
Version/
part from theparser-os
regex...... Bowser handles the OS part correctly with the new UA, and only misses the platform (which is empty). However, if I also make a similar change to
parser-platforms
:... it suddenly starts getting the OS part wrong too:
... so I'm not sure where to proceed from here, because I thought Bowser was detecting the platform after the OS.
The text was updated successfully, but these errors were encountered: