Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Googlebot recognition #278

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

rcsandell
Copy link
Contributor

Got two new user agent strings for the Googlebot, added tests and support for them.

Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5X Build/MMB29P) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.96 Mobile Safari/537.36 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)

Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; Googlebot/2.1; +http://www.google.com/bot.html) Safari/537.36

I had to reorder the position of the Googlebot test to prevent the platform browser being incorrectly detected as an unknown os Safari browser.

Also added new platform type "bot".

@coveralls
Copy link

Pull Request Test Coverage Report for Build 405

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.17%

Totals Coverage Status
Change from base Build 396: 0.02%
Covered Lines: 463
Relevant Lines: 480

💛 - Coveralls

Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine! 👍

@lancedikson lancedikson merged commit dedbe9f into bowser-js:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants