Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OS version names #338

Merged
merged 4 commits into from Jul 31, 2019
Merged

Update OS version names #338

merged 4 commits into from Jul 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2019

Add "Pie" as version name for Android 9 and add version names to macOS.

@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 648

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 89.56%
Totals Coverage Status
Change from base Build 636: 0.7%
Covered Lines: 527
Relevant Lines: 544
💛 - Coveralls

lancedikson
lancedikson approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! Will release it tomorrow.

@lancedikson lancedikson merged commit 181eb40 into bowser-js:master Jul 31, 2019
@lancedikson
Copy link
Collaborator

@joergleis fyi, it's been released as 2.5.3

@snyk-bot snyk-bot mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coveralls @lancedikson