Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QQ Browser #362

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

mk-kialo
Copy link
Contributor

This adds support for the QQ Browser (Windows, macOS, Android, iOS) and QQ Browser Lite a.k.a. QQ Browser for Mac (macOS).

Note that the "Browser" in the name is relevant, as there is a different program called simply "QQ" (an instant messenger) which can also act as a browser.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 724

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.577%

Totals Coverage Status
Change from base Build 714: 0.02%
Covered Lines: 532
Relevant Lines: 549

💛 - Coveralls

Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll release it this week.

@mk-kialo
Copy link
Contributor Author

Well thank you! 🙌

@mk-kialo
Copy link
Contributor Author

Hi @lancedikson! No pressure, just a little reminder for you and I hope that you will find the time to merge PRs soon. 😇I appreciate your work on this library. Thank you!

@lancedikson
Copy link
Collaborator

@mk-kialo, sorry, busy days. Will release it today, promise :)

@lancedikson lancedikson changed the base branch from production to master October 2, 2019 18:13
@lancedikson lancedikson merged commit 493c4fb into bowser-js:master Oct 2, 2019
@lancedikson
Copy link
Collaborator

Has been released as 2.7.0 :)

@mk-kialo
Copy link
Contributor Author

Thanks a lot! 🙌

@simo-an
Copy link

simo-an commented Jan 9, 2020

in parser-browsers.js , QQ Browser named QQ Browser Lite and 'QQ Browser

but in constants.js,the BROWSER_ALIASES_MAP's key is QQ and QQLite

does it intentionally ?

@mk-kialo
Copy link
Contributor Author

mk-kialo commented Jan 9, 2020

@weixublog yes! the browser aliases are just different names for the same thing, but shorter. See the other aliases defined such as {samsung_internet: 'Samsung Internet for Android'}.

@simo-an
Copy link

simo-an commented Jan 9, 2020

@mk-kialo

in BROWSER_MAP

  qq: 'QQ Browser',
  qqlite: 'QQ Browser Lite',
  samsung_internet: 'Samsung Internet for Android',

but in it's aliases

  QQ: 'qq',
  QQLite: 'qqlite',
  'Samsung Internet for Android': 'samsung_internet',

it's different ...

maybe, we should use QQ Browser Lite as key , rather QQLite ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants