Refactoring workflows #1182
Refactoring workflows #1182
Conversation
| # if called from the report workflow and it wasn't a new release event (it was either a cron job or a manual dispatch of the report workflow) | ||
| - name: Download frontend-build from last release | ||
| uses: dawidd6/action-download-artifact@v3 | ||
| if: inputs.report_artifact_in_scope == true && inputs.release_published == false | ||
| with: | ||
| workflow: ci.yml | ||
| event: release | ||
| name: frontend-build | ||
| path: _site |
There was a problem hiding this comment.
Mostly concerned about this one. Does it seem like the correct way ?
There was a problem hiding this comment.
I am not sure why you used ci.yml workflow here. But if you have used the ci.yml here, then the frontend-build artifact must be available in that workflow else this workflow run will fail. And as far as I can see, no frontend-build artifact is present in the ci.yml
There was a problem hiding this comment.
Have you tested the workflow? Is it running properly?
There was a problem hiding this comment.
I am not sure why you used ci.yml workflow here. But if you have used the ci.yml here, then the frontend-build artifact must be available in that workflow else this workflow run will fail. And as far as I can see, no frontend-build artifact is present in the ci.yml.
This was the reason for my question on Slack. As I mentioned there I had observed that whenever a new release happens only ci.yml runs and the chaining of workflow happens within it. So at that time when a new release happens we build the frontend just like here and because of workflow call chaining starting from the parent ci.yml this deploy-frontend.yml also gets triggered anyways but under the context of ci.yml. So that's the reason above here I wrote ci.yml to find the last frontend-build artifact and deploy-frontend.yml is anyways uploading the frontend-build artifact during this chaining run here so it will be available under the context of ci.yml workflow summary.
There was a problem hiding this comment.
Have you tested the workflow? Is it running properly?
Regarding this I've some issues. For testing this on my fork I wanted some previous release run of ci.yml on my fork to test but since I don't have one by default unlike here in Bowtie repo where multiple release runs of ci.yml are present, can you help me figure out how can I trigger a release on my fork so that ci.yml runs ? cc @Julian
| build-frontend: | ||
| uses: ./.github/workflows/build-frontend.yml | ||
| runs-on: ubuntu-latest | ||
| if: inputs.report_artifact_in_scope == false || inputs.release_published == true || github.event_name == 'pull_request' |
There was a problem hiding this comment.
here we build the frontend during a release workflow call chaining.
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: frontend-build | ||
| path: frontend/build |
There was a problem hiding this comment.
here we upload the frontend-build during a release workflow call chaining.
|
(Discussed via Slack, we'll revisit this at some point) |
@Julian @AgniveshChaubey this is my first iteration on this change. Let's discuss this further if this seems like the right way moving forward or not.
馃摎 Documentation preview 馃摎: https://bowtie-json-schema--1182.org.readthedocs.build/en/1182/