This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Port MakeImage (image editing facility) to containers/image #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikh
force-pushed
the
containers-image
branch
3 times, most recently
from
b652c59
to
4b1c660
Compare
added 2 commits
February 13, 2017 22:09
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
erikh
force-pushed
the
containers-image
branch
from
4b1c660
to
003e483
Compare
…ers/storage Signed-off-by: Erik Hollensbe <github@hollensbe.org>
erikh
force-pushed
the
containers-image
branch
from
003e483
to
f6dc7f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete port, and it uses a fork of containers/image for now, the source of which you can find here: https://github.com/erikh/image/tree/box-fork
This code alters the MakeImage function to incorporate layer editing and progress reporting features according to the following pull requests in containers/image:
Otherwise the branch tracks master.
The editing itself is considerably more reliable than our "push to docker and pray" method, and the capabilities of the library suggest we can do a lot more with images (especially OCI images) once this port is complete.