Upgrade PHPUnit to 9.5 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some issue with infection after I had to upgrade it to make it runnable with PHP 8 in #508. That's the reason why I have limited PHPUnit to version 9.2.* |
|
I'm not sure to understand. All tests pass, so what is the issue you refer to? |
|
Also, on a side note, @theofidry could you update the settings of the project to remove the build with PHP 7.2 from the list of the required checks? |
Merged
Have a look at #510 CI failures |
Merged
|
Just a quick heads up as I see several notifications: last week was very busy so sorry if I was holding up anything; I'll hope to catch up a bit tonight |
smoench
approved these changes
Dec 7, 2020
|
Thank you @villfa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.