Stop raising prometheus error metric on setup build failure

We used to increment a prometheus error counter whenever build setup failed. We did this because a failure in build setup used to kill the slave process. We fixed that in #377. Incrementing the prometheus counter is now unnecessary noise.
box · Mar 10, 2018 · 61763af · 61763af
1 parent 47bd543
commit 61763af
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/app/common/metrics.py b/app/common/metrics.py
@@ -30,7 +30,6 @@ class ErrorType(str, Enum):
     AtomizerFailure = 'AtomizerFailure'
     NetworkRequestFailure = 'NetworkRequestFailure'
     PostBuildFailure = 'PostBuildFailure'
-    SetupBuildFailure = 'SetupBuildFailure'
     SubjobStartFailure = 'SubjobStartFailure'
     SubjobWriteFailure = 'SubjobWriteFailure'
     ZipFileCreationFailure = 'ZipFileCreationFailure'

diff --git a/app/master/cluster_master.py b/app/master/cluster_master.py
@@ -232,7 +232,6 @@ def _handle_setup_failure_on_slave(self, slave):
 
         :type slave: Slave
         """
-        internal_errors.labels(ErrorType.SetupBuildFailure).inc()  # pylint: disable=no-member
         build = self.get_build(slave.current_build_id)
         build.setup_failures += 1
         if build.setup_failures >= MAX_SETUP_FAILURES: