Skip test that fails on Windows #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @josephharrington has signed the CLA. Thanks for the pull request! |
josephharrington
force-pushed
the
skip-flaky
branch
from
547fb39
to
9d0840c
Compare
See issue #345.
josephharrington
force-pushed
the
skip-flaky
branch
from
9d0840c
to
0a62b81
Compare
tjlee0909
reviewed
May 25, 2017
| from test.framework.functional.base_functional_test_case import BaseFunctionalTestCase | ||
| from test.functional.job_configs import JOB_WITH_SLEEPS | ||
|
|
||
|
|
||
| @skipIf(is_windows(), 'Fails on AppVeyor; see issue #345') |
There was a problem hiding this comment.
Can we just increase the timeout for master.block_until_build_finished() to 20 seconds or something instead of skipping this on Windows?
There was a problem hiding this comment.
Skipping is intended as a short term fix until someone can actually fix the test, perhaps by doing what you suggest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #345.