Fix Failed Subjob Result Sending #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsennewald
commented
Dec 17, 2021
rsennewald
commented
- Retry sending results on subjob completion up to 5 times with a linear sleep to resolve the issue where sometimes subjobs would fail to send on first attempt and cause a run to never send all results and show as In Progress indefinitely.
- Check if executor count is >= 0 instead of == 0 when marking a slave as idle. There was a bug where a slave could get to a negative executor count likely through a race condition and cause an Exception here.
- Rename stages of Dockerfile to be more explicit and utilize builder stage for building a test image and running tests in docker for easier local development.
- Added targets docker-lint and docker-test to Makefile for making local testing in the same docker image as we build our rpm in possible.
…ild as failed immediately.
…file after creating it." This reverts commit 51e8efc.
…timeout in test needs to be increased.
Added new target 'docker-test' to build an image and run tests in it, also updated readme for this information to make testing easier on local environments.
|
|
rsennewald
changed the title
mayurva
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.