Fix: Validation message fails to get displayed when user clicks on 'Post' without entering any comment while adding a Point Annotation. #27
Conversation
src/AnnotationDialog.js
Outdated
| * @protected | ||
| * @return {void} | ||
| */ | ||
| focusReplyEl() { |
There was a problem hiding this comment.
Could combine these two into a generic focus method that takes in a selector.
src/AnnotationDialog.js
Outdated
| @@ -330,13 +331,45 @@ class AnnotationDialog extends EventEmitter { | |||
| this.element.addEventListener('mouseup', this.stopPropagation); | |||
| this.element.addEventListener('wheel', this.stopPropagation); | |||
|
|
|||
| const replyTextEl = this.element.querySelector(`.${CLASS_REPLY_TEXTAREA}`); | |||
| if (replyTextEl) { | |||
| replyTextEl.addEventListener('keydown', this.focusReplyEl); | |||
There was a problem hiding this comment.
Should we be listening to focus so that this also fires when you click in the input?
There was a problem hiding this comment.
I think it makes more sense to remove the red border once you type something into the text area rather than when you click into it
There was a problem hiding this comment.
Played around w/ it a little more. Changing it back to fire on 'focus' rather than 'keydown'
| this.cancelEl.addEventListener('click', this.onCancel); | ||
| this.postEl.addEventListener('click', this.onPost); | ||
| if (this.hasTouch) { | ||
| this.textAreaEl.addEventListener('keydown', this.focus); |
There was a problem hiding this comment.
Does focus not fire on keydown in a mobile setting?
There was a problem hiding this comment.
Doesn't seem to
There was a problem hiding this comment.
I guess the focus event of clicking on the text area fires first usually
No description provided.