New: Show excel icons for xlsb files

box · Jun 11, 2019 · 051ba28 · 051ba28
1 parent 3a67345
commit 051ba28
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 43 deletions.
diff --git a/src/lib/icons/icons.js b/src/lib/icons/icons.js
@@ -167,7 +167,7 @@ export const ICON_FILE_MAP = {};
 });
 
 // EXCEL ICON EXTENSIONS
-['xls', 'xlsm', 'xlsx'].forEach((extension) => {
+['xls', 'xlsm', 'xlsx', 'xlsb'].forEach((extension) => {
     ICON_FILE_MAP[extension] = 'FILE_EXCEL';
 });
 

diff --git a/src/lib/viewers/office/__tests__/OfficeLoader-test.js b/src/lib/viewers/office/__tests__/OfficeLoader-test.js
@@ -6,54 +6,29 @@ import { PERMISSION_DOWNLOAD } from '../../../constants';
 const sandbox = sinon.sandbox.create();
 
 describe('lib/viewers/office/OfficeLoader', () => {
+    const fakeFileTemplate = {
+        size: 1000,
+        permissions: {
+            can_download: true
+        },
+        representations: {
+            entries: [
+                {
+                    representation: 'ORIGINAL'
+                }
+            ]
+        }
+    };
+
     afterEach(() => {
         sandbox.verifyAndRestore();
     });
 
     describe('determineViewer()', () => {
         const fakeFiles = [
-            {
-                extension: 'xlsx',
-                size: 1000,
-                permissions: {
-                    can_download: true
-                },
-                representations: {
-                    entries: [
-                        {
-                            representation: 'ORIGINAL'
-                        }
-                    ]
-                }
-            },
-            {
-                extension: 'xlsm',
-                size: 1000,
-                permissions: {
-                    can_download: true
-                },
-                representations: {
-                    entries: [
-                        {
-                            representation: 'ORIGINAL'
-                        }
-                    ]
-                }
-            },
-            {
-                extension: 'xlsb',
-                size: 1000,
-                permissions: {
-                    can_download: true
-                },
-                representations: {
-                    entries: [
-                        {
-                            representation: 'ORIGINAL'
-                        }
-                    ]
-                }
-            }
+            Object.assign({}, fakeFileTemplate, { extension: 'xlsx' }),
+            Object.assign({}, fakeFileTemplate, { extension: 'xlsm' }),
+            Object.assign({}, fakeFileTemplate, { extension: 'xlsb' })
         ];
 
         fakeFiles.forEach((fakeFile) => {