Fix: Hide filmstrip when controls hide (#239)

box · Jul 27, 2017 · 0ba7804 · 0ba7804
1 parent 01cdf3c
commit 0ba7804
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/lib/viewers/media/MediaControls.js b/src/lib/viewers/media/MediaControls.js
@@ -611,6 +611,7 @@ class MediaControls extends EventEmitter {
 
         if (this.wrapperEl && this.wrapperEl.parentNode) {
             this.wrapperEl.parentNode.classList.remove(SHOW_CONTROLS_CLASS);
+            this.filmstripHideHandler();
         }
     }
 

diff --git a/src/lib/viewers/media/__tests__/MediaControls-test.js b/src/lib/viewers/media/__tests__/MediaControls-test.js
@@ -625,6 +625,7 @@ describe('lib/viewers/media/MediaControls', () => {
     describe('hide()', () => {
         beforeEach(() => {
             stubs.isSettingsVisible = sandbox.stub(mediaControls, 'isSettingsVisible');
+            stubs.filmstripHideHandler = sandbox.stub(mediaControls, 'filmstripHideHandler');
             stubs.show = sandbox.stub(mediaControls, 'show');
         });
 
@@ -643,13 +644,14 @@ describe('lib/viewers/media/MediaControls', () => {
             expect(stubs.show).to.be.called;
         });
 
-        it('should remove the show controls class if the wrapper element and parent exist', () => {
+        it('should remove the show controls class and hide the filmstrip if the wrapper element and parent exist', () => {
             mediaControls.preventHiding = false;
             stubs.isSettingsVisible.returns(false);
 
             mediaControls.hide();
             expect(stubs.show).to.not.be.called;
             expect(mediaControls.wrapperEl.parentNode.classList.contains('bp-media-controls-is-visible')).to.be.false;
+            expect(stubs.filmstripHideHandler).to.be.called;
         });
     });