Update: Adjust default camera distance for model3d viewer (#5)

box · Mar 22, 2017 · 307e124 · 307e124
1 parent 0668a1c
commit 307e124
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/lib/viewers/box3d/Box3dAssets.js b/src/lib/viewers/box3d/Box3dAssets.js
@@ -1,8 +1,8 @@
 const STATIC_URI = 'third-party/model3d/';
 const BOX3D = [
-    `${STATIC_URI}boxsdk.js`,
+    `${STATIC_URI}boxsdk.min.js`,
     `${STATIC_URI}three.min.js`,
-    `${STATIC_URI}box3d-runtime.js`,
+    `${STATIC_URI}box3d-runtime.min.js`,
     `${STATIC_URI}webvr-polyfill.js`,
     `${STATIC_URI}WebVR/VRConfig.js`
 ];

diff --git a/src/lib/viewers/box3d/model3d/Model3dRenderer.js b/src/lib/viewers/box3d/model3d/Model3dRenderer.js
@@ -31,6 +31,7 @@ const ORIGIN_VECTOR = { x: 0, y: 0, z: 0 };
 const FLOOR_VECTOR = { x: 0, y: -1, z: 0 };
 const IDENTITY_QUATERNION = { x: 0, y: 0, z: 0, w: 1 };
 
+const PREVIEW_CAMERA_ORBIT_DISTANCE_FACTOR = 1.5;
 const PREVIEW_CAMERA_POSITION = {
     x: -0.559,
     y: 0.197,
@@ -311,7 +312,8 @@ class Model3dRenderer extends Box3DRenderer {
         // Set the origin point (so that we always point at the center of the model when the camera reloads)
         orbitController.originPoint.copy(center);
         orbitController.setPivotPosition(center);
-        orbitController.setOrbitDistance(Math.max(Math.max(maxDimension.x, maxDimension.y), maxDimension.z));
+        const distance = PREVIEW_CAMERA_ORBIT_DISTANCE_FACTOR * Math.max(Math.max(maxDimension.x, maxDimension.y), maxDimension.z);
+        orbitController.setOrbitDistance(distance);
     }
 
     /** @inheritdoc */