Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set dimensions for close button svg #1032

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

ConradJChan
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Jul 4, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

&.default-close-btn {
svg {
height: 24px;
pointer-events: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the event is handled by the parent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@ConradJChan ConradJChan closed this Jul 8, 2019
@ConradJChan ConradJChan reopened this Jul 8, 2019
@ConradJChan ConradJChan closed this Jul 8, 2019
@ConradJChan ConradJChan reopened this Jul 8, 2019
@ConradJChan ConradJChan merged commit 2c2d479 into box:master Jul 8, 2019
@ConradJChan ConradJChan deleted the banner-x branch July 8, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants