Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): add drawing button to preview controls #1296

Merged
merged 17 commits into from
Nov 19, 2020
Merged

feat(annotations): add drawing button to preview controls #1296

merged 17 commits into from
Nov 19, 2020

Conversation

ChenCodes
Copy link
Contributor

@ChenCodes ChenCodes commented Nov 19, 2020 •
edited
Loading

Changes in this PR:

  • Add drawing button to preview controls
  • Add AnnotationControlsFSM related logic for drawing button clicks
  • add unit tests

Demo:
ezgif com-gif-maker (7)

@ChenCodes ChenCodes changed the title Add drawing button to preview controls feat(annotations): add drawing button to preview controls Nov 19, 2020
@ChenCodes ChenCodes force-pushed the add-drawing-button-to-preview-controls branch from abad994 to 8023c34 Compare November 19, 2020 00:14
@jstoffan
Copy link
Collaborator

LGTM overall

@ChenCodes ChenCodes marked this pull request as ready for review November 19, 2020 00:18
@ChenCodes ChenCodes requested a review from a team as a code owner November 19, 2020 00:18
jstoffan
jstoffan reviewed Nov 19, 2020
View reviewed changes
src/lib/Preview.js Outdated Show resolved Hide resolved
@ChenCodes ChenCodes merged commit f88ba0e into box:master Nov 19, 2020
@ChenCodes ChenCodes deleted the add-drawing-button-to-preview-controls branch November 19, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenCodes @jstoffan @ConradJChan