Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Preview should allow disabling of auto focus #833

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

priyajeet
Copy link
Contributor

@priyajeet priyajeet commented Aug 21, 2018

default autoFocus is true

@boxcla
Copy link

boxcla commented Aug 21, 2018

Verified that @priyajeet has signed the CLA. Thanks for the pull request!

@jstoffan
Copy link
Collaborator

This doesn't change the current behavior, it just allows folks to disable autofocus; is that intentional? It doesn't directly solve the issue in the PR title, just supports it as an option.

@priyajeet priyajeet changed the title Fix: Preview should not auto focus itself on load unless told to do so Update: Preview should allow disabling of auto focus Aug 22, 2018
@priyajeet
Copy link
Contributor Author

Fixed title

@jstoffan jstoffan self-requested a review August 22, 2018 01:26
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test failing, but otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants