Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add hover state to thumbnails #965

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

ConradJChan
Copy link
Contributor

Screen Shot 2019-03-26 at 1 45 57 PM

@boxcla
Copy link

boxcla commented Mar 26, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

// Appends to the lastChild which should be the thumbnail nav element
thumbnailEl.lastChild.appendChild(imageEl);
// Appends to the thumbnail nav element
thumbnailEl.lastChild.firstChild.appendChild(imageEl);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selection logic is getting pretty hairy. Can we avoid the extra wrapper?

@ConradJChan ConradJChan merged commit 096b183 into box:master Mar 26, 2019
@ConradJChan ConradJChan deleted the thumbnails-hover branch March 26, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants