fix(pdf): Re-enable support for unverified signatures in PDF files #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jstoffan
commented
Aug 29, 2019
| echo "-----------------------------------------------------------------------------------" | ||
| echo "Tweaking pdf.js for Chrome..." | ||
| echo "-----------------------------------------------------------------------------------" | ||
| sed -e 's/function supportsMozChunkedClosure/!\(\/Chrome\/\.test\(navigator\.userAgent\)\) \&\& function supportsMozChunkedClosure/' -i '' src/third-party/doc/${DOC_STATIC_ASSETS_VERSION}/pdf.js |
There was a problem hiding this comment.
This modification is no longer needed, as the code it references was removed from PDF.js a few versions ago.
mickr
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally tested this feature using a file with an image signature rather than an e-signature, which led to a false positive. I believe these assets will be deployed to the CDN with the next box-content-preview release, which means 2.17.0 should still be viable, as it's using the the 2.16.0 assets.