feat(docviewer): Toggle find bar control #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
mxiao6
reviewed
Oct 24, 2019
|
I think this may need to be rebased |
ConradJChan
force-pushed
the
find-icon-toolbar
branch
from
8ba2229
to
8562e22
Compare
ConradJChan
changed the title
jstoffan
previously approved these changes
Oct 31, 2019
ConradJChan
force-pushed
the
find-icon-toolbar
branch
from
8562e22
to
509578a
Compare
mickr
approved these changes
Nov 6, 2019
| * @return {boolean} | ||
| */ | ||
| isFindDisabled() { | ||
| const canDownload = checkPermission(this.options.file, PERMISSION_DOWNLOAD); |
There was a problem hiding this comment.
very minor: I think the intention with this const is to be more readable so I would probably add the negation in the const creation and name it as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And don't worry about the consistency with the zoom in/out icons because they'll be changing