-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Upgrade React dependencies to v17 #1334
Conversation
52703b2
to
523e1f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
||
usePreventKey(buttonElRef, ['Enter', 'Space']); | ||
if (key === 'Enter' || key === 'Space') { | ||
event.stopPropagation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
||
// Allow the range input to handle its own left/right keydown events | ||
if (key === 'ArrowLeft' || key === 'ArrowRight') { | ||
event.stopPropagation(); // Prevents global key handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this comment be applied above to MediaToggle
as well?
Tested against our React viewers (CSV, ZIP) and the new React controls.