Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): Allow annotations for editable shared links #1462

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat(annotations): Allow annotations for editable shared links #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lib/viewers/BaseViewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,8 @@ class BaseViewer extends EventEmitter {
this.rootEl.classList.add(CLASS_BOX_PREVIEW_MOBILE);
}

// Creates a promise that the annotator will be constructed if annotations are
// enabled and the expiring embed is not a shared link
if (this.areAnnotationsEnabled() && !this.options.sharedLink) {
// Creates a promise that the annotator will be constructed if annotations are enabled
if (this.areAnnotationsEnabled()) {
this.annotatorPromise = new Promise(resolve => {
this.annotatorPromiseResolver = resolve;
});
Expand Down