Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Rename viewers #29

Merged
merged 8 commits into from
Apr 5, 2017
Merged

Chore: Rename viewers #29

merged 8 commits into from
Apr 5, 2017

Conversation

JustinHoldstock
Copy link
Contributor

This can wait until after today's release has been cut

@JustinHoldstock JustinHoldstock changed the title Rename viewers to name viewer Rename viewers Mar 28, 2017
@MiiBond
Copy link
Contributor

MiiBond commented Mar 29, 2017

This is probably a bit pedantic but, if we're renaming 3d to 3D, shouldn't we also rename Ui to UI?
So, Box3DUIUtils.js instead of Box3DUiUtils.

@JustinHoldstock
Copy link
Contributor Author

@mbond, good catch. Doing this now

@priyajeet priyajeet changed the title Rename viewers Chore: Rename viewers Mar 29, 2017
@jeremypress
Copy link
Contributor

We might want to change our instance names in our test files. for example
let image = new ImageViewer({}) should become let imageViewer = new ImageViewer({})

@JustinHoldstock JustinHoldstock merged commit 9f03d9f into box:master Apr 5, 2017
@pramodsum pramodsum mentioned this pull request Nov 14, 2017
Merged
pramodsum added a commit to pramodsum/box-content-preview that referenced this pull request Nov 14, 2017
@pramodsum
Update: box-annotations to v0.3.0
2ba0266 
https://github.com/box/box-annotations/releases

# 0.3.0 (2017-11-14)
* Chore: Add conventional-changelog-releaser (box#34) ([624e0bd](box/box-annotations@624e0bd))
* Chore: Do not clear out node_modules on when publishing npm package (box#30) ([08c180d](box/box-annotations@08c180d))
* Fix: Do not select drawings when creating a point annotation on top (box#28) ([07fc4c1](box/box-annotations@07fc4c1))
* Fix: Drawing CSS (box#23) ([0493fcd](box/box-annotations@0493fcd))
* Fix: fix highlight selection and typos (box#21) ([ca54d5e](box/box-annotations@ca54d5e)), closes [box#21](box/box-annotations#21)
* Fix: Hide createHighlightDialog on page re-render (box#31) ([0b74717](box/box-annotations@0b74717))
* Fix: Match width of reply textarea with comments (box#33) ([5f0f29b](box/box-annotations@5f0f29b))
* Fix: Only registering thread with controller on save (box#22) ([ff75bf1](box/box-annotations@ff75bf1))
* Fix: Only show create dialog when creating new point annotations (box#29) ([4822ece](box/box-annotations@4822ece))
* Fix: only show newly created annotation dialog on hover (box#25) ([0ba1965](box/box-annotations@0ba1965))
* Fix: Position create dialog properly near page edges (box#32) ([968efb3](box/box-annotations@968efb3))
* Fix: release script should use correct remote branch (box#20) ([8bd12a5](box/box-annotations@8bd12a5))
* Fix: Scrolling on highlight dialogs in powerpoints (box#24) ([b21ed0e](box/box-annotations@b21ed0e))
* Fix: Validation message fails to get displayed when user clicks on 'Post' without entering any comme ([d90e72c](box/box-annotations@d90e72c))
*  Fix: Hide mobile dialog on first outside click (box#26) ([01ec48b](box/box-annotations@01ec48b))
pramodsum added a commit that referenced this pull request Nov 14, 2017
@pramodsum
Update: box-annotations to v0.3.0 (#485)
a786dfe 
https://github.com/box/box-annotations/releases

# 0.3.0 (2017-11-14)
* Chore: Add conventional-changelog-releaser (#34) ([624e0bd](box/box-annotations@624e0bd))
* Chore: Do not clear out node_modules on when publishing npm package (#30) ([08c180d](box/box-annotations@08c180d))
* Fix: Do not select drawings when creating a point annotation on top (#28) ([07fc4c1](box/box-annotations@07fc4c1))
* Fix: Drawing CSS (#23) ([0493fcd](box/box-annotations@0493fcd))
* Fix: fix highlight selection and typos (#21) ([ca54d5e](box/box-annotations@ca54d5e)), closes [#21](box/box-annotations#21)
* Fix: Hide createHighlightDialog on page re-render (#31) ([0b74717](box/box-annotations@0b74717))
* Fix: Match width of reply textarea with comments (#33) ([5f0f29b](box/box-annotations@5f0f29b))
* Fix: Only registering thread with controller on save (#22) ([ff75bf1](box/box-annotations@ff75bf1))
* Fix: Only show create dialog when creating new point annotations (#29) ([4822ece](box/box-annotations@4822ece))
* Fix: only show newly created annotation dialog on hover (#25) ([0ba1965](box/box-annotations@0ba1965))
* Fix: Position create dialog properly near page edges (#32) ([968efb3](box/box-annotations@968efb3))
* Fix: release script should use correct remote branch (#20) ([8bd12a5](box/box-annotations@8bd12a5))
* Fix: Scrolling on highlight dialogs in powerpoints (#24) ([b21ed0e](box/box-annotations@b21ed0e))
* Fix: Validation message fails to get displayed when user clicks on 'Post' without entering any comme ([d90e72c](box/box-annotations@d90e72c))
*  Fix: Hide mobile dialog on first outside click (#26) ([01ec48b](box/box-annotations@01ec48b))
pramodsum added a commit to pramodsum/box-content-preview that referenced this pull request Nov 16, 2017
@pramodsum
Update: box-annotations to v0.3.1
6244a83 
https://github.com/box/box-annotations/releases

# 0.3.0 (2017-11-14)
* Chore: Add conventional-changelog-releaser (box#34) ([624e0bd](box/box-annotations@624e0bd))
* Chore: Do not clear out node_modules on when publishing npm package (box#30) ([08c180d](box/box-annotations@08c180d))
* Fix: Do not select drawings when creating a point annotation on top (box#28) ([07fc4c1](box/box-annotations@07fc4c1))
* Fix: Drawing CSS (box#23) ([0493fcd](box/box-annotations@0493fcd))
* Fix: fix highlight selection and typos (box#21) ([ca54d5e](box/box-annotations@ca54d5e)), closes [box#21](box/box-annotations#21)
* Fix: Hide createHighlightDialog on page re-render (box#31) ([0b74717](box/box-annotations@0b74717))
* Fix: Match width of reply textarea with comments (box#33) ([5f0f29b](box/box-annotations@5f0f29b))
* Fix: Only registering thread with controller on save (box#22) ([ff75bf1](box/box-annotations@ff75bf1))
* Fix: Only show create dialog when creating new point annotations (box#29) ([4822ece](box/box-annotations@4822ece))
* Fix: only show newly created annotation dialog on hover (box#25) ([0ba1965](box/box-annotations@0ba1965))
* Fix: Position create dialog properly near page edges (box#32) ([968efb3](box/box-annotations@968efb3))
* Fix: release script should use correct remote branch (box#20) ([8bd12a5](box/box-annotations@8bd12a5))
* Fix: Scrolling on highlight dialogs in powerpoints (box#24) ([b21ed0e](box/box-annotations@b21ed0e))
* Fix: Validation message fails to get displayed when user clicks on 'Post' without entering any comme ([d90e72c](box/box-annotations@d90e72c))
*  Fix: Hide mobile dialog on first outside click (box#26) ([01ec48b](box/box-annotations@01ec48b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiiBond MiiBond MiiBond approved these changes

@jeremypress jeremypress jeremypress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinHoldstock @MiiBond @jeremypress @tonyjin